Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery: Handle old gallery shortcode in Classic Text block, or use Switcher #1728

Closed
jasmussen opened this issue Jul 5, 2017 · 2 comments
Closed

Gallery: Handle old gallery shortcode in Classic Text block, or use Switcher #1728

jasmussen opened this issue Jul 5, 2017 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Milestone
Merge: Editor

Comments

@jasmussen
Copy link
Contributor

We have a new gallery block. But existing galleries created using the shortcode will still work.

We need to handle the shortcode better. That is both conversion from the shortcode to the new gallery, and perhaps the other way too. This could happen through the switcher, or it could happen as a button in the inspector. We also need to figure out how to preview the shortcode gallery. It already renders fine in the Classic Text block, so perhaps simply convert it to that.
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jul 5, 2017
@jasmussen jasmussen added this to the Beta 0.8.0 milestone Jul 5, 2017
@westonruter westonruter mentioned this issue Jul 9, 2017
Closed
@karmatosed karmatosed added the [Priority] High Used to indicate top priority items that need quick attention label Aug 3, 2017
@mtias mtias modified the milestones: Beta 0.9.0, Beta 0.8.0 Aug 10, 2017
@mtias mtias modified the milestones: 0.10.0, Beta 0.9.0 Aug 18, 2017
@aduth
Copy link
Member

aduth commented Aug 24, 2017

Related (potential duplication): #2454

@ellatrix
Copy link
Member

I agree that this is a duplicate. Also related to #2478 which would handle shortcodes on paste (raw content). I need to redo that one a bit after the recent paste commits.

@karmatosed karmatosed modified the milestones: 0.11.0, 0.10.0 Aug 25, 2017
@aduth aduth mentioned this issue Aug 31, 2017
Closed
@karmatosed karmatosed modified the milestones: Beta 1.2, Beta 1.1 Sep 4, 2017
@mtias mtias modified the milestones: Beta, Needs to happen, Beta 1.2 Sep 6, 2017
@mtias mtias closed this as completed Nov 20, 2017
@jeherve jeherve mentioned this issue Jan 15, 2018
Closed
@snyk-bot snyk-bot mentioned this issue Nov 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Merge: Editor
Development

No branches or pull requests
5 participants
@karmatosed @mtias @jasmussen @aduth @ellatrix