Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block unaware of edits to image #16977

Closed
rogerlos opened this issue Aug 9, 2019 · 3 comments
Closed

Image block unaware of edits to image #16977

rogerlos opened this issue Aug 9, 2019 · 3 comments
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended

Comments

@rogerlos
Copy link

rogerlos commented Aug 9, 2019

If you drag an image into the image block while editing a post and then edit the image (to, say, rotate it), Gutenberg is unaware of the edited changes if you use the block controls to switch to a different image size after the edit.

Steps to reproduce the behavior:

  1. Add an image to your post by using the image block and dragging an image to it.
  2. Use the pencil icon on the block to edit the image, and then within the media modal choose "edit image".
  3. Rotate the image, save, and update the media.
  4. Return to edit your post, and in the image block inspector, change the image size.

What you will see in the editor once you change the size is the image as it was before it was edited. Exiting the post editor and re-entering it will show you the correct image.

@rogerlos
Copy link
Author

rogerlos commented Aug 9, 2019

Post preview also seems unaware of the edits, FWIW.

@swissspidy swissspidy added [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended [Feature] Media Anything that impacts the experience of managing media labels Aug 9, 2019
@youknowriad
Copy link
Contributor

Isn't this a browser cache issue? Also, I think it's probably related to server-side code, so creating a trac ticket might be better here.

@paaljoachim
Copy link
Contributor

Testing:

Using WordPress 5.6.1
Theme: Twenty Twenty One
No plugins activated.
Chrome
A local test site that I use.
OSX 10.15.7

Testing instructions:

  1. Add an image to your post by using the image block and dragging an image to it.
  2. Use the pencil icon on the block to edit the image, and then within the media modal choose "edit image".
  3. Rotate the image, save, and update the media.
  4. Return to edit your post, and in the image block inspector, change the image size.

Added an Image block. Dragged an image into it.
Clicked the Replace button. Within the media modal. I clicked the Edit button.
Clicked the Crop tool. Rotated image. Clicked Apply.
Saved draft.
Exited screen and re entered. Noticed that the image had reset itself.


Same test with beta 1 of WordPress 5.7
(WordPress Beta Tester plugin is activated.)

This time the image showed as rotated.

Conclusion for WordPress 5.7 this issue has been fixed.
I will go ahead and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants