Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic Text block still has "Freeform" tag name #1695

Closed
hedgefield opened this issue Jul 4, 2017 · 2 comments
Closed

Classic Text block still has "Freeform" tag name #1695

hedgefield opened this issue Jul 4, 2017 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks

Comments

@hedgefield
Copy link

hedgefield commented Jul 4, 2017

When you add a Classic Text block (the name of which we settled on in #1326), the code version still looks like

<!-- wp:core/freeform -->
<p class="wp-block-freeform"></p>
<!-- /wp:core/freeform -->

If we're gonna commit to the name we should also change the tag.

Version 0.3.0

@swissspidy swissspidy added the [Feature] Blocks Overall functionality of blocks label Jul 4, 2017
@karmatosed karmatosed changed the title 0.3.0: Classic Text block still has "Freeform" tag name Classic Text block still has "Freeform" tag name: version 0.3.0 Jul 4, 2017
@karmatosed karmatosed changed the title Classic Text block still has "Freeform" tag name: version 0.3.0 Classic Text block still has "Freeform" tag name Jul 4, 2017
@youknowriad
Copy link
Contributor

This won't harm backwards compatibility since it's the default block used if no matching block is found.

@mtias
Copy link
Member

mtias commented Aug 18, 2017

The plan is to not show comment/name for this block.

@mtias mtias closed this as completed Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

4 participants