Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make only styling you can do available #1677

Closed
karmatosed opened this issue Jul 3, 2017 · 2 comments
Closed

Make only styling you can do available #1677

karmatosed opened this issue Jul 3, 2017 · 2 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

The strikethrough is only available on highlighted text, this actually makes a lot of sense. However, you see it as an option even when not highlighting. Perhaps thls does not make as much sense?

strike

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Jul 3, 2017
@kevinwhoffman
Copy link
Contributor

The current strikethrough behavior seems in line with bold and italic, in that a click toggles the behavior on and off. Some users may prefer to toggle it on before they begin typing, rather than typing, then highlighting, then clicking strikethrough. I think it's best to keep it consistent with the bold and italic controls as it is now.

@karmatosed
Copy link
Member Author

As a flow we've improved things and so closing this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants