Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement link editing #16633

Closed
draganescu opened this issue Jul 17, 2019 · 4 comments
Closed

Implement link editing #16633

draganescu opened this issue Jul 17, 2019 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block [Status] Blocked Used to indicate that a current effort isn't able to move forward

Comments

@draganescu
Copy link
Contributor

Once a link is added to the menu we need to be able to edit it.

@draganescu draganescu added the Needs Design Needs design efforts. label Jul 17, 2019
@karmatosed
Copy link
Member

Can't you repurpose the existing editing of link design over having another one? There does feel like a strong pattern already exists here.

@draganescu
Copy link
Contributor Author

In the design offered by #13690 the flow is quite different from the two places where links can be edited.

In the navigation block we need to edit in a dropdown:

Screenshot 2019-07-18 at 13 23 20

In the button block we have a URL input always present:

Screenshot 2019-07-18 at 13 23 44

In the link editing of RichText we have a popover:

Screenshot 2019-07-18 at 13 24 04

My problem is which pattern and how to merge it into the dropdown?

1st option is to edit the link in the dropdown with an edit icon next to it. It is kinda clunky though and the nesting would be so much: Menu > Item > Dropdown > Link > Edit.

2nd option is to remove the "Edit label text" dropdown entry and replace it with "Edit link". Edit label text is useless because label text is editable immediately after the item is selected.

When Edit link is pressed we would get the link in the dropdown editable like the link input of the button component. I can test that and see how it works. @sarahmonster

@karmatosed
Copy link
Member

I'll leave this to others to add insight, but for me adding a link should be a consistent experience.

@noisysocks noisysocks added [Status] Blocked Used to indicate that a current effort isn't able to move forward [Block] Navigation Affects the Navigation Block and removed Needs Design Needs design efforts. labels Jul 31, 2019
@noisysocks
Copy link
Member

Closing this. #17539 tracks enhancements to the Menu item block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] Blocked Used to indicate that a current effort isn't able to move forward
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants