Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: fix the tabs focus style #1644

Closed
swissspidy opened this issue Jul 2, 2017 · 4 comments
Closed

Inserter: fix the tabs focus style #1644

swissspidy opened this issue Jul 2, 2017 · 4 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time
Milestone

Comments

@swissspidy
Copy link
Member

Currently the focus style looks like this:

screen shot 2017-07-02 at 19 49 30

The tab with the focus key needs some z-index love here. Even z-index: 2 already works.

Note: I can't seem to be able to trigger it with the keyboard, because pressing tab automatically goes to the blocks list. See #1606 (comment) for a possible solution to that.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Design labels Jul 22, 2017
@afercia afercia changed the title Inserter: fix focus style Inserter: fix the tabs focus style Aug 1, 2017
@jasmussen jasmussen added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 18, 2017
@karmatosed karmatosed added this to the Beta, Needs to happen milestone Sep 24, 2017
@josephfusco
Copy link

I can't seem to reproduce this.

Tabbing through seems to lock the focus into an infinite cycle within the current tab content with no obvious way on how to change tabs.

@afercia
Copy link
Contributor

afercia commented Oct 20, 2017

Tabbing to the tabs is currently broken, known issue and pending a final decision on the inserter functionalities to be fixed.

Accessibility of the inserter worked at some point (there were no tabs) see #527. Then the introduction of tabs didn't address keyboard navigation. The inserter has seen other changes under the hood, I hope it will be in a stable state soon so we can address accessibility.

@afercia
Copy link
Contributor

afercia commented Oct 20, 2017

See also #1497 (comment)

@jasmussen
Copy link
Contributor

Pretty sure this is fixed by #3080.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

6 participants