Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Slug Direction in RTL version #16400

Open
rachidev84 opened this issue Jul 2, 2019 · 3 comments
Open

Issue Slug Direction in RTL version #16400

rachidev84 opened this issue Jul 2, 2019 · 3 comments
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@rachidev84
Copy link

This issue occure when you switching wordpress to arabic language :
about RTL :
the permalink display in RTL not in LTR, it must be in LTR because that how it show on all browser.
this is how it look like on wordpress in edit post :
https://prnt.sc/o76dkn

and this is how must be : https://www.byarabic.com/مقالة-الموقع/
Another issue is if someone copy my post link from website and past it in other place via facebook messenger or any browser it show them url with %%%% like this :
https://www.byarabic.com/%d9%85%d9%82%d8%a7%d9%84%d8%a9-%d8%a7%d9%84%d9%85%d9%88%d9%82%d8%b9/

@swissspidy swissspidy added [Feature] Permalink The permalink of a post or page and the experience of setting or editing it Internationalization (i18n) Issues or PRs related to internationalization efforts labels Jul 2, 2019
@draganescu
Copy link
Contributor

Hi @swissspidy I see you labeled this so I am asking you for a second opinion :) wouldn't this be better off as a ticket in core Trac?

@sabernhardt
Copy link
Contributor

sabernhardt commented Jun 17, 2022

Core has a Trac ticket, but some aspects need to be changed in the editor.

So far, I have two suggestions for the post-publish panel:

  1. The URL input field needs direction: ltr. If you can rely on the WordPress admin common.css, it adds that style in an ltr class, and I think its code class could be a better choice.
  2. Try decoding the URL in the Copy button with { safeDecodeURIComponent( link ) } as the text value, which is used for the input.
    value={ safeDecodeURIComponent( link ) }

    <CopyButton text={ link } onCopy={ this.onCopy }>

@sabernhardt
Copy link
Contributor

sabernhardt commented Jul 20, 2022

In the Gutenberg 13.7 Summary panel, the button text is URL encoded. Also, that URL should have direction: ltr, and the link in the popup needs display: inline-block or similar for the direction to work.

new Gutenberg Summary panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Permalink The permalink of a post or page and the experience of setting or editing it Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants