Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block: Editing the video removes it from the editor #14172

Closed
arunsathiya opened this issue Feb 28, 2019 · 2 comments
Closed

Video Block: Editing the video removes it from the editor #14172

arunsathiya opened this issue Feb 28, 2019 · 2 comments
Labels
[Block] Video Affects the Video Block

Comments

@arunsathiya
Copy link
Contributor

Describe the bug
When a video block is added, and when one clicks on the Edit icon on the block, the video disappears from the editor. Refreshing the page brings it back though.

To Reproduce
Steps to reproduce the behavior:

  • Add a video block
  • Add a video on it. I drag-dropped the file
  • Click on the Edit pencil icon available at the top

Expected behavior

I am not entirely sure what's expected here, but is a video editing tool expected to popup? Like this one that appears when using the classic-editor?

screenshot 2019-02-28 at 22 32 46

What happens instead

The block just disappears from the editor view. Refreshing the page shows that it's still available.

screenshot 2019-02-28 at 22 00 17

The block buttons to upload new video files can be seen again.

Desktop (please complete the following information):

  • Device: MacBook Pro
  • OS: macOS 10.14.2 - Mac OS Mojave
  • Browser: Google Chrome Version 72.0.3626.109 (Official Build) (64-bit)
@swissspidy swissspidy added the [Block] Video Affects the Video Block label Mar 1, 2019
@Soean
Copy link
Member

Soean commented Mar 3, 2019

Thanks for your feedback. This is the expected behavior for now. We are working on additional features like alternate file formats and subtitles at the moment. This will change this button.

@Soean
Copy link
Member

Soean commented Jan 13, 2020

We now use the MediaReplaceFlow component in all media related blocks. See #19162

@Soean Soean closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Video Affects the Video Block
Projects
None yet
Development

No branches or pull requests

3 participants