Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperator block ends up full-width #14102

Closed
karmatosed opened this issue Feb 25, 2019 · 5 comments
Closed

Seperator block ends up full-width #14102

karmatosed opened this issue Feb 25, 2019 · 5 comments
Labels
[Block] Separator Affects the Separator Block [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

Often the theme's <hr> styling will override any differentiation between wide and short separators, and both end up full-width.

Issue made from block audit #8970. Props @kjellr and @sarahmonster.

@jorgefilipecosta
Copy link
Member

Hi @karmatosed, @kjellr, @sarahmonster,
What would be the ideal way to address this problem, should we increase the specificity of our styles to make sure they overwrite theme ones?

@jorgefilipecosta jorgefilipecosta added [Type] Enhancement A suggestion for improvement. [Block] Separator Affects the Separator Block labels Feb 26, 2019
@sarahmonster
Copy link
Member

Some examples of this in action:

Twenty seventeen:
screenshot 2019-02-26 11 39 23

Twenty sixteen:

screenshot 2019-02-26 11 48 30

Twenty fifteen:
screenshot 2019-02-26 11 49 36

Atomic blocks:
screenshot 2019-02-26 11 51 18

_s:
screenshot 2019-02-26 11 51 55

It looks as though we'd need to set a width attribute on the default .wp-block-separator element. Since the default separator doesn't have a specific class, you'd either need to use chained :not statements:

.wp-block-separator:not(.is-style-wide):not(.is-style-dots) {
    max-width: 100px;
}

...or add an additional class to the default .wp-block-separator, and apply the styling directly to that.

If the :not solution seems sensible (and like it wouldn't be likely to break anything), I can make a PR for this.

@webmandesign
Copy link
Contributor

The issue was also discussed in #10569

@paaljoachim
Copy link
Contributor

Is this issue still valid?

@paaljoachim
Copy link
Contributor

I will go ahead and close this issue as it seems like this has been taken care of in various associated issues/PR's. If I am mistaken then please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Separator Affects the Separator Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants