Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform video shortcodes to video blocks #14002

Closed
mmtr opened this issue Feb 21, 2019 · 1 comment · Fixed by #14042
Closed

Transform video shortcodes to video blocks #14002

mmtr opened this issue Feb 21, 2019 · 1 comment · Fixed by #14042
Labels
[Block] Video Affects the Video Block [Feature] Shortcodes Related to shortcode functionality [Type] Enhancement A suggestion for improvement.

Comments

@mmtr
Copy link
Contributor

mmtr commented Feb 21, 2019

It would be great if the video block contains a transform for the video shortcode.

That way, when opening an old post containing a [video] shortcode (or when pasting it in a new post), they are converted automatically to video blocks like we do with the gallery or caption shortcodes.

It seems that all the shortcode options except width and height are supported by the video block attributes, so we might need to add new attributes for the width and height (or maybe just ignore them).

@mmtr mmtr added [Type] Enhancement A suggestion for improvement. [Feature] Shortcodes Related to shortcode functionality [Block] Video Affects the Video Block labels Feb 21, 2019
@nfmohit
Copy link
Member

nfmohit commented Feb 22, 2019

Submitted PR #14042 addressing this enhancement ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Video Affects the Video Block [Feature] Shortcodes Related to shortcode functionality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants