Missing return statement on line 175 of packages/components/src/drop-zone/provider.js

[jasonculligan]

Should there be a return statement in the toUpdate.map callback at line 175 of packages/components/src/drop-zone/provider.js ?

[jorgefilipecosta]

Hi @jasonculligan, thank you for opening this issue 👍 In PR #13953 I describe what happened and I added a change to make sure future people reading the code don't get the same perception.

[aduth]

If possible, it would be worth exploring a lint rule which enforces an assumption that Array#map would always be either used as the value of a return statement, or as the initializer to a variable declaration.

[aduth]

@jasonculligan Out of curiosity, did you come across the error as the result of some automated tooling, or just by glancing over the code?

[jorgefilipecosta]

If possible, it would be worth exploring a lint rule which enforces an assumption that Array#map would always be either used as the value of a return statement, or as the initializer to a variable declaration.

Nice idea I will look into having a rule implemented.

[jasonculligan]

@aduth I used SonarCube Community Edition Version 7.6 (build 21501) which reported the find as a blocker type bug.