-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider consolidating the appearance of the Code and HTML Blocks #13934
Comments
As an alternative view, I'd suggest that these two blocks should be styled more differently. They are very different blocks, with very different functionalities. The Code block displays code inside of a Perhaps something as simple as a background color applied to Screenshots |
Is this about styling only the editor UI, or the block itself (back and front match)? |
Both - as they should match. And valid point. ✅ |
After discussing this in the Design Team slack today, we agreed to add the numbered lines to visualize the Code block and show up for both Editor and frontend, with the option to turn them off. |
Adding line numbers to the Code Block is a very good idea! A thought that come up as I again read through the above comments. |
Please don't! That is a job for themes, not the editor or the block. color options are especially difficult to overcome if the editor has styles for it. |
Good point Joy. |
As originally noted in #8435, the Code and HTML blocks are very similar in appearance. They're close, but they have some minor differences. The reason for these differences is not immediately apparent.
Since both are essentially code editors, I'd suggest we adjust them to use the same styles. My suggestion would be to change the Code block as the base, since it more closely matches the borders used when you switch to the code editor (light gray border, no rounded corners).
Screenshots
De-selected:
Selected:
The text was updated successfully, but these errors were encountered: