Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Block: Latest Comments #13931

Open
melchoyce opened this issue Feb 18, 2019 · 6 comments
Open

Update Block: Latest Comments #13931

melchoyce opened this issue Feb 18, 2019 · 6 comments
Labels
[Block] Latest Comments Affects the Latest Comments Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant Needs Design Needs design efforts. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later
Milestone

Comments

@melchoyce
Copy link
Contributor

Moved over from #1792.

Like Calendar and Archive, I looked at what a more dynamic Recent Comments block could include.

I focused on exploring the “what if’s” — what if you could approve pending comments in the Recent Comments block? What if you could reply to them?

image

View Prototype

Does this make sense? Should we try it out?

@melchoyce melchoyce added Needs Design Feedback Needs general design feedback. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Accessibility Feedback Need input from accessibility labels Feb 18, 2019
@karmatosed
Copy link
Member

karmatosed commented Feb 18, 2019

I love this idea. On one hand, it sits on the line whether it is an actual plugin/extending. On other, I love the idea that blocks become more dynamic.

@afercia
Copy link
Contributor

afercia commented Feb 22, 2019

Quickly discussed during today's accessibility bug-scrub and, besides the technical challenge (as far as I can tell this block is rendered server side, not sure it can be made dynamic) we have concerns about the overall proposal.

In terms of interaction, we don’t think the post content is the place to manage comments.

Also, with regards to approving comments, worth considering the widget-block by default displays only approved comments. That's its main purpose, as it's very unlikely authors want to display pending comments on the front end.

Same applies to replying: not sure the post content is the right place for a complex interaction that should display an additional form with additional controls etc. That would be an unexpected interaction, especially for users with accessibility needs.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Accessibility Feedback Need input from accessibility labels Feb 22, 2019
@mapk
Copy link
Contributor

mapk commented Jun 4, 2019

In the spirit of everything is a block, I really like this idea. I see it working in the context of block templates which is yet to come in the near future.

Can we create a future label for this?

@gziolo gziolo added this to the Future milestone Oct 10, 2019
@gziolo gziolo removed the future label Oct 10, 2019
@paaljoachim
Copy link
Contributor

A Latest Comments Block would be natural to include in a Query Block used in Full Site Editing.
It would likely not be included in the content of a page or post.

@enriquesanchez enriquesanchez added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Apr 6, 2020
@paaljoachim
Copy link
Contributor

We discussed this during the Gutenberg Design Triage, and agreed that this would be a part of Full Site Editing.
We need to circle around to this issue again sometime in the future.

@noisysocks noisysocks removed the [Feature] Widgets Screen The block-based screen that replaced widgets.php. label Aug 14, 2020
@kellychoffman kellychoffman added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels May 17, 2021
@skorasaurus skorasaurus added Needs Decision Needs a decision to be actionable or relevant [Block] Latest Comments Affects the Latest Comments Block labels Oct 17, 2022
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@youknowriad
Copy link
Contributor

I was checking old issues and came through this one now that we have FSE. Personally, I don't think like interacting with comments (managing them) in the editor is a good idea. Maybe in the frontend if you're an admin or things like that but I'm just tempted to just close this issue personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Comments Affects the Latest Comments Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant Needs Design Needs design efforts. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later
Projects
None yet
Development

No branches or pull requests