Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require brackets to be used in the shortcode block #12939

Closed
Orrison opened this issue Dec 17, 2018 · 3 comments
Closed

Do not require brackets to be used in the shortcode block #12939

Orrison opened this issue Dec 17, 2018 · 3 comments
Labels
[Feature] Shortcodes Related to shortcode functionality

Comments

@Orrison
Copy link

Orrison commented Dec 17, 2018

Since we now have an entirely separate block for shortcodes why do we continue to require brackets to be used for shortcodes within that block?

It should be optional, if the end user finds it visually nicer to include the brackets that is fine. But since shortcodes are the only thing that should be input in a shortcode block it seems natural that simply typing the shortcode name and arguments within the block should work as well.

Right now it just outputs what is written in it as text.

@swissspidy swissspidy added the [Feature] Shortcodes Related to shortcode functionality label Dec 17, 2018
@swissspidy
Copy link
Member

In the long term, shortcodes should be replaced by blocks. Why now change the expected formats of shortcodes and teach people new formats? What if people write nested shortcodes in that field?

We'd have to save them with the added brackets anyway for backward compatibility. So I don't see any value in changing this in the UI only.

@Orrison
Copy link
Author

Orrison commented Dec 17, 2018

Hmm okay, that makes sense.

I guess it leads back into #10790 and #7357 (comment) where some input validation would be awesome in this blocks field.

It can be embarrassing accidentally not adding the brackets and all of a sudden text is output onto your site rather than the expected shortcode. So some helper to the end user letting them know they need to add a shortcode/the brackets can be helpful.

If y'all feel this isn't worth the time since you are hoping to phase out shortcodes anyways I can understand, but if that isn't going to be happening in the near future some additional UX would be great.

Appreciate all you do!

@aduth
Copy link
Member

aduth commented Jan 30, 2019

Thanks for the report. I'm inclined to close this in favor of #10790, i.e. feedback improvements for shortcode validity within the block. I expect that the block will always continue to require the brackets, unless design revisions are made to indicate that the text field of the block is intended to be the segment of text between the brackets (not currently the case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes Related to shortcode functionality
Projects
None yet
Development

No branches or pull requests

3 participants