Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow canceling out of setup / edit state #12401

Closed
alexislloyd opened this issue Nov 28, 2018 · 2 comments
Closed

Allow canceling out of setup / edit state #12401

alexislloyd opened this issue Nov 28, 2018 · 2 comments
Labels
Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective.
Milestone

Comments

@alexislloyd
Copy link
Contributor

Currently, if you go into the "edit" state for a block that offers this option, there is no way to cancel out of that screen and retain the content you had. For example, if I have an image block with an image loaded in it, then I click on the edit button from the image block toolbar, but decide that I don't want to change the image after all, I can't get out of that screen and go back.

I propose adding a text link at the bottom of the edit state to cancel out of that view, as shown in the GIF below. The only question this raises is whether that cancel link should be present in the initial setup state as well or only when you get to this state after having content in the block?

screen capture on 2018-11-21 at 16-33-50

@draganescu
Copy link
Contributor

draganescu commented Feb 13, 2019

Specifically for the image block, the behaviour of the Edit icon varies based on the kind of image it contains, from URL or from the media library:

  • if I add an image from an URL, then click on the edit Icon, I get to the initial block screen, where I can either upload, add from media library or from URL
  • if I upload or add from media library, then click on the edit button, I get the Select or Upload Media dialog.

This means I cannot simply switch in the same block between an image from the media library or an image from an URL. Is this as intended?

Edit: yes it is as intended, apparently there is a hard line between the media modal and the block which is hard to erase.

@melchoyce
Copy link
Contributor

Fixed in #14142. See #14795 for adding "cancel" to more blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective.
Projects
None yet
Development

No branches or pull requests

4 participants