Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE inline formating can not be changed in Gutenberg #12248

Closed
paaljoachim opened this issue Nov 23, 2018 · 4 comments
Closed

TinyMCE inline formating can not be changed in Gutenberg #12248

paaljoachim opened this issue Nov 23, 2018 · 4 comments
Labels
Needs Testing Needs further testing to be confirmed.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Nov 23, 2018

Describe the bug
Inline heading color made through TinyMCE toolbar can not be changed in Gutenberg.
I also tested coloring one word in a paragraph through TinyMCE and that can also not be changed in Gutenberg.

To Reproduce
Steps to reproduce the behavior:

  1. Add a heading and an inline color using the TinyMCE classic editor.
  2. Activate Gutenberg.
  3. Notice the inline heading color is still in use. Even changing the CSS and using !important does not help.
  4. The heading inline color stays and can not easily be removed.

Expected behavior
Inline heading color made through the TinyMCE toolbar in the classic editor is removed. To show the default black color. OR even better. Add the color controls to the heading block: #8171

Bottom line is that functionality that exist in TinyMCE today should be
directly transferred into Gutenberg,

Desktop (please complete the following information):

  • OS: MAC OSX 10.13.6
  • Browser Chrome using Desktop Server.
  • Gutenberg version: 4.5.1

Additional context
I had to deactivate Gutenberg. Go to the page using the inline heading and remove the color I added. Then I went to reactivate Gutenberg again the inline color was gone.

@paaljoachim
Copy link
Contributor Author

NB! Follow the above procedure and color one word in the paragraph through the TinyMCE toolbar in the classic editor. Then change to Gutenberg. Notice the inline color also for paragraph stays in place. Changing the full paragraph color changes all the text except the word colored through TinyMCE.

I am adding the above information to this same issue as it seems to be the same error happening in heading and paragraph. There might be other unique TinyMCE options that also do not carry over to Gutenberg.

@paaljoachim paaljoachim changed the title TinyMCE inline heading color can not be changed in Gutenberg TinyMCE inline formating can not be changed in Gutenberg Nov 23, 2018
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 23, 2018
@ellatrix
Copy link
Member

You can change it in the HTML?

@paaljoachim
Copy link
Contributor Author

Hey Ella

I am pleasantly surprised how well using TinyMCE transfers over til Gutenberg.
I would say the only problem is what I mentioned above the rest works well.
I switched to HTML and removed the inline color.
I am looking forward to having all the existing TinyMCE toolbar options in place.

Thanks.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Nov 28, 2018

Btw here are some tests:

Testing most of the TinyMCE toolbar buttons:
screen shot 2018-11-27 at 21 16 09

Activating Gutenberg:
screen shot 2018-11-27 at 21 17 20

Converting to blocks:
screen shot 2018-11-27 at 21 17 46

Edit the HTML:
screen shot 2018-11-27 at 21 19 26

The tests I ran shows that TinyMCE to Gutenberg works really well. There are of course some buttons missing from Gutenberg that should perhaps be added into the sidebar panel in paragraph and heading etc blocks. Such as inline coloring of text and coloring text background. Thanks for having created the plugin to handle these things Ella. https://wordpress.org/plugins/advanced-rich-text-tools/ So that anyone for now can install and use it through that until the features have been added to core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

3 participants