Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back-compat of add_editor_style() and other similar functions #10766

Closed
joyously opened this issue Oct 18, 2018 · 2 comments
Closed

back-compat of add_editor_style() and other similar functions #10766

joyously opened this issue Oct 18, 2018 · 2 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@joyously
Copy link

It seems there are several places where themes or plugins need to check which editor is being used.
Could those checks be absorbed into existing core functions so it is more invisible? (like every plugin checking and every theme checking adds more code) etc.
Can we make the existing functions more smart to do it for them?

  • add_editor_style
  • TinyMCE buttons
  • metabox functions?
    probably others
@Soean Soean added the Backwards Compatibility Issues or PRs that impact backwards compatability label Oct 18, 2018
@danielbachhuber danielbachhuber added the [Status] Needs More Info Follow-up required in order to be actionable. label Oct 30, 2018
@danielbachhuber
Copy link
Member

Hi @joyously:

Can we make the existing functions more smart to do it for them?

I'm not sure I follow. Can you describe what you mean in this case?

Generally, on the topic of backwards compatibility, we're trying to make the transition experience as invisible as possible. However, some existing Classic Editor features don't have exact parity in Gutenberg, so it's not possible to enable the feature automatically, so some intervention will be needed on behalf of the developer.

Previously #7913

@danielbachhuber
Copy link
Member

Closing per #7913 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

3 participants