Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't focus title of demo content (don't focus when title exists) #10601

Closed
tofumatt opened this issue Oct 14, 2018 · 5 comments
Closed

Don't focus title of demo content (don't focus when title exists) #10601

tofumatt opened this issue Oct 14, 2018 · 5 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@tofumatt
Copy link
Member

See:
#9608 (comment)

We should avoid focusing the title of the demo content as it skips over part of the content, which is something we should avoid on the demo page (which serves to intro users to Gutenberg content).

@tofumatt tofumatt added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Oct 14, 2018
@tofumatt tofumatt added this to the Merge: Accessibility milestone Oct 14, 2018
@tofumatt tofumatt self-assigned this Oct 14, 2018
@aduth
Copy link
Member

aduth commented Oct 15, 2018

Is this really relevant for merge if the demo post is not intended to persist into the merge?

@tofumatt
Copy link
Member Author

Oh wait, is that the case? There won't be a demo post for NUX?

If there's no demo post in WordPress 5.0 then this isn't relevant. We can just close it.

@aduth
Copy link
Member

aduth commented Oct 15, 2018

There won't be a demo post for NUX?

This is my understanding, and has been reiterated throughout development (e.g. #8551 (comment)).

Unless there's a last-minute decision to the contrary, I'll assume it's not meant to be included in 5.0.

@tofumatt
Copy link
Member Author

I'm gonna use the "I'm kinda new here" excuse despite working on Gutenberg since April.

That makes sense, but I just wasn't sure. Figured I'd track in case it's staying, which it seems it very clearly isn't. (Closed!) Thanks! 👍

@tofumatt tofumatt reopened this Oct 15, 2018
@tofumatt
Copy link
Member Author

lol and I hit the wrong button and reopened. Closing 4 realz now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants