From ccc0d514ef7f35fb93b329e3f3aaea72c63fc3d7 Mon Sep 17 00:00:00 2001 From: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Date: Wed, 7 Sep 2022 14:38:45 +1000 Subject: [PATCH] Social Icons: Add missing padding support, update margin support (#43885) --- docs/reference-guides/core-blocks.md | 2 +- packages/block-library/src/social-links/block.json | 3 ++- packages/block-library/src/social-links/style.scss | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index ea015225d355b..24839c7311000 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -761,7 +761,7 @@ Display icons linking to your social media profiles or sites. ([Source](https:// - **Name:** core/social-links - **Category:** widgets -- **Supports:** align (center, left, right), anchor, color (background, gradients, ~~enableContrastChecker~~, ~~text~~), spacing (blockGap, margin, units) +- **Supports:** align (center, left, right), anchor, color (background, gradients, ~~enableContrastChecker~~, ~~text~~), spacing (blockGap, margin, padding, units) - **Attributes:** customIconBackgroundColor, customIconColor, iconBackgroundColor, iconBackgroundColorValue, iconColor, iconColorValue, openInNewTab, showLabels, size ## Spacer diff --git a/packages/block-library/src/social-links/block.json b/packages/block-library/src/social-links/block.json index 6ba9f32040ffc..a7707cf195134 100644 --- a/packages/block-library/src/social-links/block.json +++ b/packages/block-library/src/social-links/block.json @@ -67,7 +67,8 @@ }, "spacing": { "blockGap": [ "horizontal", "vertical" ], - "margin": [ "top", "bottom" ], + "margin": true, + "padding": true, "units": [ "px", "em", "rem", "vh", "vw" ], "__experimentalDefaultControls": { "blockGap": true diff --git a/packages/block-library/src/social-links/style.scss b/packages/block-library/src/social-links/style.scss index b8da15c08b447..582edd4f22bac 100644 --- a/packages/block-library/src/social-links/style.scss +++ b/packages/block-library/src/social-links/style.scss @@ -1,4 +1,7 @@ .wp-block-social-links { + // This block has customizable padding, border-box makes that more predictable. + box-sizing: border-box; + padding-left: 0; padding-right: 0; // Some themes set text-indent on all <ul>