From 2e9a9aae13fc4386338edca15ad2760a89890a7b Mon Sep 17 00:00:00 2001 From: brookewp Date: Sat, 10 Dec 2022 01:16:57 -0800 Subject: [PATCH] remove margin overrides for components --- packages/components/CHANGELOG.md | 2 ++ packages/components/src/color-picker/component.tsx | 1 + packages/components/src/color-picker/styles.ts | 5 ----- packages/components/src/query-controls/index.js | 1 + 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 7ed9fc6779bba..1903f9b52b4b6 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -31,6 +31,7 @@ - Lighten the border color on control components ([#46252](https://github.com/WordPress/gutenberg/pull/46252)). - `Popover`: Prevent unnecessary paint when scrolling by using transform instead of top/left positionning ([#46187](https://github.com/WordPress/gutenberg/pull/46187)). - `CircularOptionPicker`: Prevent unecessary paint on hover ([#46197](https://github.com/WordPress/gutenberg/pull/46197)). +- `ColorPicker` & `QueryControls`: Replace bottom margin overrides with `__nextHasNoMarginBottom` ([#46448](https://github.com/WordPress/gutenberg/pull/46448)). ### Experimental @@ -58,6 +59,7 @@ - `TabPanel`: Add ability to set icon only tab buttons ([#45005](https://github.com/WordPress/gutenberg/pull/45005)). ### Internal + - `AnglePickerControl`: remove `:focus-visible' outline on `CircleOutlineWrapper` ([#45758](https://github.com/WordPress/gutenberg/pull/45758)) ### Bug Fix diff --git a/packages/components/src/color-picker/component.tsx b/packages/components/src/color-picker/component.tsx index 9e4777aec3eec..bb5caedb8082a 100644 --- a/packages/components/src/color-picker/component.tsx +++ b/packages/components/src/color-picker/component.tsx @@ -97,6 +97,7 @@ const ColorPicker = ( diff --git a/packages/components/src/color-picker/styles.ts b/packages/components/src/color-picker/styles.ts index 0058cb90f4710..bf25707ba9c93 100644 --- a/packages/components/src/color-picker/styles.ts +++ b/packages/components/src/color-picker/styles.ts @@ -9,7 +9,6 @@ import styled from '@emotion/styled'; import NumberControl from '../number-control'; import InnerSelectControl from '../select-control'; import InnerRangeControl from '../range-control'; -import { StyledField } from '../base-control/styles/base-control-styles'; import { space } from '../ui/utils/space'; import { boxSizingReset } from '../utils'; import Button from '../button'; @@ -111,10 +110,6 @@ export const ColorfulWrapper = styled.div` } ${ interactiveHueStyles } - - ${ StyledField } { - margin-bottom: 0; - } `; export const CopyButton = styled( Button )` diff --git a/packages/components/src/query-controls/index.js b/packages/components/src/query-controls/index.js index e62d71eb2d8eb..79343c5954c94 100644 --- a/packages/components/src/query-controls/index.js +++ b/packages/components/src/query-controls/index.js @@ -35,6 +35,7 @@ export default function QueryControls( { return [ onOrderChange && onOrderByChange && (