-
Notifications
You must be signed in to change notification settings - Fork 7
Design Explorations: Installed results that are disabled #14
Comments
Would it make sense to have the "Enable" link be a button here? |
I was worried it'd get noisy if you have a bunch of disabled results, but I'll try mocking it up 👍 |
Other idea — don't show an enable button at all, and instead turn the block back on if they select one. |
This is reminding me a little bit of the problem we ran into over in WordPress/gutenberg#14224. In the end, we just went with a checkbox, but here are definitely some relevant explorations in the following comments: |
Related (h/t @karmatosed): WordPress/gutenberg#15121 |
@melchoyce I really like the last idea of just showing the blocks without additional links or buttons. The text at the top explains what's going on; "We did find these other disabled blocks." Of course, that might need a copy review. Once the user selects a block, it's automatically enabled again. 👍 This keeps the Block Inserter (Library) from getting too complicated. Especially in light of the upcoming Block Directory changes, it might begin to get overwhelmed with varrying design patterns. |
Hi @melchoyce, I've started to implement this but I hit a road bump. For example:
So, can we do something like this for V1?
Or I can hide disabled blocks from the results. |
Let's hide disabled blocks from results for the v1. |
Just checking in on the status of this so we can keep this repo synced and updated with issues. @ck-lee is this now implemented? |
@karmatosed This doesn't appear to be implemented yet. |
@melchoyce @karmatosed @ck-lee Is this a problem with the block directory or custom blocks in general? If I manually install a block, then disable it, do I not follow the same path? The reason why this distinction matters is that the problem that @ck-lee ran into is a problem with the logic in Gutenberg's 'core' library, more specific: the The Issue that @mapk linked above is related. |
Disregard my previous comment 😳🙂. I've had a few chats and I think the block directory is the better place to address this :) |
What if you search for something a plugin you've downloaded includes, but you've disabled it?
The text was updated successfully, but these errors were encountered: