Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress.Security.ValidatedSanitizedInput.MissingUnslash does not accept stripslashes() #2402

Closed
Oreolek opened this issue Nov 8, 2023 · 3 comments

Comments

@Oreolek
Copy link

Oreolek commented Nov 8, 2023

This is weird, but WordPress.Security.ValidatedSanitizedInput.MissingUnslash sniff accepts only stripslashes_deep (type-ignorant) or stripslashes_from_strings_only (type-ignorant) and does not accept the plain type-strict stripslashes.

@kkmuffme
Copy link

Because stripslashes isn't enough since it doesn't act recursively I guess? (e.g. if the type is an array)

@Oreolek
Copy link
Author

Oreolek commented Mar 26, 2024

but what if the type is not an array?

@kkmuffme
Copy link

phpcs is not static analysis, so it wouldn't know.

@jrfnl jrfnl closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants