Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension Controls Support Page #69

Closed
annezazu opened this issue Nov 10, 2021 · 4 comments
Closed

Dimension Controls Support Page #69

annezazu opened this issue Nov 10, 2021 · 4 comments
Assignees
Labels
5.9 Changes in 5.9 release block editor Gutenberg related issues user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@annezazu
Copy link
Collaborator

annezazu commented Nov 10, 2021

Pulled from this slack convo, I plan to approach this by adding an overall dimension controls page that then has link on each respective block page to that page. Pulled from this overview issue WordPress/gutenberg#28356 here are the blocks to update:

Need to include padding, margin, min-height, block gap, etc.

@annezazu annezazu self-assigned this Nov 22, 2021
@zzap zzap added 5.9 Changes in 5.9 release user documentation (HelpHub) Improvements or additions to end-user documentation block editor Gutenberg related issues labels Nov 30, 2021
@annezazu
Copy link
Collaborator Author

Whew have a draft: https://wordpress.org/support/?p=15242206&post_type=helphub_article&preview=1&_ppp=8374967e92

@carolinan or @mkaz would either of you bhance be able to review?

@annezazu annezazu moved this from Todo to In Progress in WP 5.9 Documentation Jan 12, 2022
@carolinan
Copy link
Collaborator

Hi!
The text flows well and is easy to read.

The two first blocks in the image below "How to find dimension controls" have the dimension panel closed, which I found confusing. It felt like the main focus of those images where the typography- and color controls instead.

Types of controls, padding;

This setting impacts the space behind a block’s content and its border.

I believe this should be space between, not space behind?

Types of controls, margin;

You can find this in option in blocks like Columns block.

I think the first in needs to be removed.

Block spacing
This setting can easily be misunderstood.
It controls the spacing between blocks that are inside the block that displays the setting (button block inside buttons block).
-I am not sure how to explain that in an easy way.

@annezazu
Copy link
Collaborator Author

Thanks so much for reviewing per usual <3.

The two first blocks in the image below "How to find dimension controls" have the dimension panel closed, which I found confusing. It felt like the main focus of those images where the typography- and color controls instead.

Great point. For whatever reason, I didn't think to close those tabs out as a way to get a condensed shot. Updated!

I believe this should be space between, not space behind?

Updated 🤦🏼

I think the first in needs to be removed.

Updated 💥

Block spacing. This setting can easily be misunderstood. It controls the spacing between blocks that are inside the block that displays the setting (button block inside buttons block). I am not sure how to explain that in an easy way.

I struggled with this too. Thank you for flagging that issue too. Great context on where folks are likely to get confused. To help resolve this, I added in slightly more context to that section and added an additional demo showing the block spacing controls for the parent buttons block and padding controls for the nested blocks.

At this point, shipping: https://wordpress.org/support/article/dimension-controls-overview/ We can iterate from there.

Repository owner moved this from In Progress to Done in WP 5.9 Documentation Jan 17, 2022
@annezazu
Copy link
Collaborator Author

Added in a link to dimension controls docs to the following docs:

For columns and spacer, these were removed and will be added back in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.9 Changes in 5.9 release block editor Gutenberg related issues user documentation (HelpHub) Improvements or additions to end-user documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants