Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for attributes on links, images, and codes #123

Closed
Witiko opened this issue Mar 27, 2022 · 2 comments · Fixed by #256
Closed

Add support for attributes on links, images, and codes #123

Witiko opened this issue Mar 27, 2022 · 2 comments · Fixed by #256
Labels
feature request good first issue lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Milestone
2.22.0

Comments

@Witiko
Copy link
Owner

Witiko commented Mar 27, 2022 •
edited
Loading

Since version 2.15.0 (#91), Markdown has had renderers for attributes and attribute contexts. However, the Lua parser only supports attributes on headings and not on other elements such as links, images, and codes. Future development should add syntax extensions such as Pandoc's link_attributes, inline_code_attributes, fenced_code_attributes for specifying attributes on elements other than headings.
@Witiko Witiko added feature request lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation labels Mar 27, 2022
@Witiko Witiko added this to the 2.16.0 milestone Mar 27, 2022
@Witiko
Copy link
Owner Author

Witiko commented Apr 28, 2022

This issue is blocked by issue #126.

@Witiko Witiko modified the milestones: 2.16.0, 2.17.0 May 18, 2022
@Witiko Witiko mentioned this issue Jun 16, 2022
Closed
@Witiko
Copy link
Owner Author

Witiko commented Jul 18, 2022

jgm#36 implements fenced_code_attributes and part of link_attributes. Perhaps we can backport them to witiko/markdown?

@Witiko Witiko modified the milestones: 2.17.0, 2.18.0 Jul 27, 2022
@Witiko Witiko mentioned this issue Jul 31, 2022
Closed
@Witiko Witiko modified the milestones: 2.16.0, 2.17.0 Aug 25, 2022
@Witiko Witiko added good first issue syntax extension Related to syntax extensions and dialects of markdown labels Sep 1, 2022
@Witiko Witiko modified the milestones: 2.17.0, 3.0.0 Sep 21, 2022
@Witiko Witiko modified the milestones: 2.17.0, 2.18.0 Sep 29, 2022
@Witiko Witiko modified the milestones: 2.18.0, 3.0.0 Oct 24, 2022
@Witiko Witiko modified the milestones: 3.0.0, 2.19.0 Nov 4, 2022
@Witiko Witiko mentioned this issue Nov 8, 2022
Merged
6 tasks
@Witiko Witiko modified the milestones: 2.19.0, 2.20.0 Nov 11, 2022
@Witiko Witiko removed this from the 2.20.0 milestone Nov 30, 2022
@Witiko Witiko added this to the 2.19.0 milestone Nov 30, 2022
@Witiko Witiko modified the milestones: 2.19.0, 2.20.0 Dec 14, 2022
@Witiko Witiko mentioned this issue Dec 15, 2022
Closed
@Witiko Witiko mentioned this issue Dec 28, 2022
Closed
@Witiko Witiko mentioned this issue Jan 25, 2023
Merged
6 tasks
@Witiko Witiko modified the milestones: 2.20.0, 2.21.0 Feb 1, 2023
@Witiko Witiko modified the milestones: 2.21.0, 2.22.0 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Milestone
2.22.0
Development

Successfully merging a pull request may close this issue.

Add support for attributes on links, images, and inline code spans Witiko/markdown
1 participant
@Witiko