Missing intermediate unchanged lines in inline display

[Wilfred]

Before.nix:

{config, ...}:
{
  programs.direnv = {
    enable = true;
    enableBashIntegration = true;
  };
}
{
  programs.direnv = {
    enable = true;
    enableBashIntegration = true;
  };
}

After.nix:

{config, ...}:
{
  programs.direnv = {
    enable = true;
    enableBashIntegration = true;
    nix-direnv.enable = true;
  };
}
{
  programs.direnv = {
    enable = true;
    enableBashIntegration = true;
    nix-direnv.enable = true;
  };
}

[voidus]

This is really misleading and I don't think I can use inline with this bug, here's an example of how it looks:

bot.py --- 2/14 --- Python
99
100    @client.event
101    async def on_ready():
102        await client.change_presence()
103        print('We have logged in as {0.user}'.format(client))
110            if not message.content.startswith('$'):
112            elif '\n' in message.content:
   105     print("We have logged in as {0.user}".format(client))
   113         if not message.content.startswith("$"):
   115         elif "\n" in message.content:
   116             await error_message(
   117                 message.channel, "Can't use multiline messages when using commands."
   118             )
   119             return

[imiric]

Can this issue be prioritized? 🙏 inline mode is unusable with this bug.

Here's a Go example:

And correctly shown by delta:

[scott2000]

2764292 doesn't look like it resolves this issue. Was the issue number wrong?

[Wilfred]

This is a GitHub bug where submodule commits close issues in the parent repo :(

[alexjwilliams]

Is there any chance we can get some movement on this? It looks like @yuja has a patch here: yuja@441371b that fixes this duplicate issue: #704.

[kaffarell]

Would be really nice to have this, the display=inline mode is otherwise kinda useless.

[TheSpyder]

I just hit an issue where, by inline mode suppressing unchanged context between removed content, it also suppressed some added lines related to the context it skipped. That's moving beyond useless to completely unacceptable.

[dnnr]

@TheSpyder If it actually hid modifications that changed the meaning of the code, then this surely warrants opening a separate issue. This one here is ultimately just about a UX improvement, not about correctness. At the very least, it would help if you could provide a concrete sample that demonstrates what you've seen.

[TheSpyder]

I can try. It's in a closed source codebase, I'm not sure I will be able to make a standalone sample.