Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with React 16 #36

Closed
ixrock opened this issue Oct 4, 2017 · 5 comments
Closed

Not working with React 16 #36

ixrock opened this issue Oct 4, 2017 · 5 comments

Comments

@ixrock
Copy link

ixrock commented Oct 4, 2017

Error related to https://github.com/Wildhoney/ReactShadow/blob/master/src/react-shadow.js#L293
and might some others..

@Wildhoney
Copy link
Owner

Thanks @ixrock — I'll take a look at supporting React 16.x 👍

@gurkerl83
Copy link

Hi, the problem is related to

Wildhoney/Keo#37

DOM Factories are from React 16 upwards available in an external react library called react-dom-factories.

Thanks!

@Wildhoney
Copy link
Owner

See facebook/react#11037

Rendering into a shadow boundary has been resolved, but not yet released. Will update ReactShadow once it has 👍

@natew
Copy link

natew commented Nov 9, 2017

Just wondering, seems like that was merged. Should this "just work" again? Or will this library need updates? If someone can confirm it should work I can give it a test.

@Wildhoney
Copy link
Owner

There weren't any substantial changes required to make it work with React 16.1.x. However, I've updated the codebase and pushed as v16.1.0 so we can mirror React versions.

All should be good now 👍 Please create new tickets for any issues you may find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants