Unit Tests

[Gankra]

We should probably start doing some unit tests to avoid regressions on features. I don't even care if it's just a bunch of small rooms with chests that just trigger features or something. Anything to more easily test things than "walk all the way through these 5 rooms and back again".

[Gankra]

@Fugiman has suggested TestSwarm + BrowserStack as a possible solution.

Having not read anything on the matter, I will also suggest considering QUnit, which is what jQuery uses to do their testing.

[veritasUnae]

I might like to do this, because I'm getting sick of the project I have to do for a course in uni and this is cooler.
QUnit seems close enough to JUnit that it might be familiar. We're just looking for some basic rooms running, getting code coverage and path coverage, etc?

[Gankra]

Yeah, basically.

Relatedly, the master branch should probably be replaced with basically a demo of all the features. If someone adds a new feature in we could add that to the demo as a sort of integration test. Ideally it would also demonstrate the "ideal" structure of a project (which openbound_part1 really doesn't reflect these days).

[veritasUnae]

Okay. I'll see what I can do, I guess. I'm in the midst of reading all of the documentation.

[veritasUnae]

gah i hope i'm doing everything ok re workflow. sigh.

[Gankra]

Feel free to ask many any questions. It's not particularly well documented. openbound_part2 is pretty close to a "good" project structure these days.

[veritasUnae]

Right, no worries. I'll probably have a bunch.
But of course, that'll help bring things to the forefront to fix in the wiki! (which i would also probably be happy doing)

But just to check workflow...

basically at the moment i forked this into veritasunae/Sburb and then made a dev branch and i've started a tests folder which will hold the xmls and i'm assuming some qunit stuff. and when i'm all done i'll commit to dev, then merge dev to the master of my fork and then submit a request to merge my fork back in with this main repo?

in my course we're all working in the one repo so i haven't really touched push / pull requests through tickets, etc.

[FugiTech]

submit a request to merge your dev into the main master, then when it is accepted you can pull it into your local master ;)