Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Provider Autoloading for Laravel 5.5 #3

Open
jagDanJu opened this issue Dec 23, 2017 · 3 comments
Open

Add Service Provider Autoloading for Laravel 5.5 #3

jagDanJu opened this issue Dec 23, 2017 · 3 comments
Assignees

Comments

@jagDanJu
Copy link

jagDanJu commented Dec 23, 2017

Add this to the composer.jso to autoload den Service Provider. There ist no need to add this manually on Laravel 5.5 :)

"extra": {
    "laravel": {
        "providers": [
            "Webklex\\GitHook\\Providers\\LaravelServiceProvider“
        ]
    }
}
@Webklex
Copy link
Owner

Webklex commented Jan 1, 2018

Hi @jagDanJu ,
thanks for your sugestion but this repository supports all Laravel versions from 5.0.0 on. So by adding this I would breake older systems..

@Webklex Webklex closed this as completed Jan 1, 2018
@jagDanJu
Copy link
Author

jagDanJu commented Jan 1, 2018

@Webklex I dont think that you would break older systems .. < 5.5 this will be ignored. Than the User needs to add the Service Provider manually

@Webklex
Copy link
Owner

Webklex commented Jan 1, 2018

@jagDanJu well that would be greate. I'll run a little test and release a new version soon :)

Best regards

@Webklex Webklex reopened this Jan 1, 2018
@Webklex Webklex self-assigned this Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants