Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install and test with Python and fslavwutils #13

Closed
wants to merge 10 commits into from

Conversation

effigies
Copy link

Gets tests working from Python 3.6-3.11. 2.7 clashes with fslavwutils, which prevents testing while there's an fsl dependency.

It looks like there's not a lot of testing going on (coverage is 5%)... Do you have test data you use to actually run the program? I know there are some proprietary files we probably can't publish, but presumably we could make some identity file just to make sure the code is exercised and changes don't damage that.

@coalsont
Copy link
Member

I don't think we have any fake coefficient files at the moment, and the real ones are considered proprietary manufacturer info, yes.

@glasserm
Copy link

Does anyone understand the coefficient file enough to know how to make an identity coefficient file for the perfect scanner?

@effigies
Copy link
Author

It turned out to be trivial. I haven't looked through all of the coefficient file formats, but at least for Siemens, the code is creating zero arrays and then updating them from the files. By creating an empty file, we use all-zero coefficients, and it turns out that this produces unwarped files that are unchanged from the source.

This at least gets coverage up to 64%.

I think this is a good place to start. It won't replace manual checks with vendor files, but should at least make it obvious if a refactor breaks things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants