CI: Enable GitHub Actions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
commented
Aug 23, 2023
| - name: Checkout repo | ||
| uses: actions/checkout@v3 | ||
| # - name: Set up Python ${{ matrix.python-version }} | ||
| # uses: conda-incubator/setup-miniconda@v2 |
There was a problem hiding this comment.
I'm going to try using miniconda instead of the standard Python setup, as conda still allows Python 2 to be installed. It will also allow us to install the FSL tools needed.
There was a problem hiding this comment.
See #12 for removing the fsl dependency, it is only used for fslval / fslorient.
|
Do you want this merged now, or do you want to figure out the conda setup or FSL removal first? |
|
I'd prefer to merge this first so that further proposals can be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #10.
GitHub actions won't start running on a pull request. It needs to be present in master. This will get it going with an absolutely minimal action, and then we can open a new PR, uncomment the tests, make sure they work, and update packaging.