Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop subleading terms #18

Closed
og113 opened this issue Sep 30, 2024 · 1 comment · Fixed by #19
Closed

Drop subleading terms #18

og113 opened this issue Sep 30, 2024 · 1 comment · Fixed by #19
Labels
enhancement New feature or request

Comments

@og113
Copy link
Collaborator

og113 commented Sep 30, 2024

At the moment we are including all channels, whether or not they appear at leading log. This is helpful for comparison against other computations, and useful if we want to go beyond leading log in the future. However, it would also be helpful to be able to explicitly truncate everything beyond leading log, so let's add a function/option for it.
@og113 og113 added the enhancement New feature or request label Sep 30, 2024
@pschicho pschicho linked a pull request Oct 2, 2024 that will close this issue
Remove DRalgo and factor code to only contain model generation from DRalgo #19
Merged
@pschicho
Copy link
Collaborator

pschicho commented Oct 2, 2024

A potential fix was implemented in PR #19 .

@og113 og113 closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DRalgo and factor code to only contain model generation from DRalgo Wall-Go/WallGoMatrix
2 participants
@og113 @pschicho