New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small issues with `start()` method's type/data checks #47

Open

marcoscaceres opened this issue Mar 4, 2022 · 0 comments

Contributor

marcoscaceres commented Mar 4, 2022

Elsewhere, @reillyeon wrote:

checking whether options['signal'] is aborted should also happen before changing the state to "starting".

A few lines just need to be moved around to return a rejected promise before setting the state machine.

marcoscaceres mentioned this issue

Fixup permission checks and promise resolution #46

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment