From 7303dec75b2f8d0263c1c7f2cc53bfdf6e6e1787 Mon Sep 17 00:00:00 2001 From: Liam Brady Date: Thu, 14 Sep 2023 17:33:40 -0400 Subject: [PATCH 1/3] have automatic beacons always send out --- spec.bs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/spec.bs b/spec.bs index a12f4ce..eda659a 100644 --- a/spec.bs +++ b/spec.bs @@ -1449,16 +1449,18 @@ successful [=navigate|navigation=] to a [=top-level traversable=]. 1. Let |beacon data| be |config|'s [=fenced frame config instance/fenced frame reporter=]'s [=fenced frame reporter/automatic beacon data=]. - 1. If |beacon data| is null, abort these steps. + 1. Let |event data| be |beacon data|'s [=automatic beacon data/eventData=] if |beacon data| is not null, the empty string otherwise. 1. If |sourceOrigin| is not [=same origin=] with |config|'s [=fenced frame config instance/mapped url=]'s [=url/origin=], abort these steps. - 1. [=list/For each=] |destination| of |beacon data|'s [=automatic beacon data/destination=]: + 1. [=list/For each=] |destination| of |config|'s [=fenced frame config instance/fenced frame reporter=]'s [=fenced frame reporter/fenced frame reporting metadata reference=]'s [=fencedframetype/fenced frame reporting map=]'s [=map/keys=]: - 1. Run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame - reporter=] with |destination|, |eventType|, and |beacon data|'s [=automatic beacon data/ - eventData=]. + 1. If |beacon data|'s [=automatic beacon data/destinations=] [=list/contains=] |destination|, run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame + reporter=] with |destination|, |eventType|, and |event data|. + + Otherwise, run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame + reporter=] with |destination|, |eventType|, and the empty string. 1. If |beacon data|'s [=automatic beacon data/once=] is true, set |config|'s [=fenced frame config instance/fenced frame reporter=]'s [=fenced frame reporter/automatic beacon data=] to From 77e695d955f3dbe1008836bebd1ea365850763ed Mon Sep 17 00:00:00 2001 From: Liam Brady Date: Thu, 14 Sep 2023 17:44:21 -0400 Subject: [PATCH 2/3] fix formatting --- spec.bs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/spec.bs b/spec.bs index eda659a..8d7c399 100644 --- a/spec.bs +++ b/spec.bs @@ -1449,18 +1449,22 @@ successful [=navigate|navigation=] to a [=top-level traversable=]. 1. Let |beacon data| be |config|'s [=fenced frame config instance/fenced frame reporter=]'s [=fenced frame reporter/automatic beacon data=]. - 1. Let |event data| be |beacon data|'s [=automatic beacon data/eventData=] if |beacon data| is not null, the empty string otherwise. + 1. Let |event data| be |beacon data|'s [=automatic beacon data/eventData=] if |beacon data| is not + null, the empty string otherwise. 1. If |sourceOrigin| is not [=same origin=] with |config|'s [=fenced frame config instance/mapped url=]'s [=url/origin=], abort these steps. - 1. [=list/For each=] |destination| of |config|'s [=fenced frame config instance/fenced frame reporter=]'s [=fenced frame reporter/fenced frame reporting metadata reference=]'s [=fencedframetype/fenced frame reporting map=]'s [=map/keys=]: + 1. [=list/For each=] |destination| of |config|'s [=fenced frame config instance/fenced frame + reporter=]'s [=fenced frame reporter/fenced frame reporting metadata reference=]'s + [=fencedframetype/fenced frame reporting map=]'s [=map/keys=]: - 1. If |beacon data|'s [=automatic beacon data/destinations=] [=list/contains=] |destination|, run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame + 1. If |beacon data|'s [=automatic beacon data/destinations=] [=list/contains=] |destination|, + run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame reporter=] with |destination|, |eventType|, and |event data|. - Otherwise, run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame - reporter=] with |destination|, |eventType|, and the empty string. + Otherwise, run [=report an event=] using |config|'s [=fenced frame config instance/fenced + frame reporter=] with |destination|, |eventType|, and the empty string. 1. If |beacon data|'s [=automatic beacon data/once=] is true, set |config|'s [=fenced frame config instance/fenced frame reporter=]'s [=fenced frame reporter/automatic beacon data=] to From d598d241af8d351f45c77386f9fec5487556ba4d Mon Sep 17 00:00:00 2001 From: Liam Brady Date: Fri, 22 Sep 2023 11:14:37 -0400 Subject: [PATCH 3/3] Add WPT --- spec.bs | 1 + 1 file changed, 1 insertion(+) diff --git a/spec.bs b/spec.bs index 8d7c399..20f563f 100644 --- a/spec.bs +++ b/spec.bs @@ -1475,6 +1475,7 @@ successful [=navigate|navigation=] to a [=top-level traversable=]. /fenced-frame/automatic-beacon-two-events-clear.https.html /fenced-frame/automatic-beacon-two-events-persist.https.html /fenced-frame/automatic-beacon-unfenced-top.https.html + /fenced-frame/automatic-beacon-no-destination.https.html