From 1895dcca3e9ccd629e3972a024d46d6ce49e141f Mon Sep 17 00:00:00 2001 From: Jacob Alber Date: Wed, 14 Feb 2024 16:46:30 -0500 Subject: [PATCH] fix: Build break on Ubuntu 2004 The C++ compiler on our image of Ubuntu 2004 cannot properly pick up Offset<> => Offset. Make this explicit. --- vowpalwabbit/fb_parser/tests/read_span_tests.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vowpalwabbit/fb_parser/tests/read_span_tests.cc b/vowpalwabbit/fb_parser/tests/read_span_tests.cc index f1e62d98789..37aec159bd8 100644 --- a/vowpalwabbit/fb_parser/tests/read_span_tests.cc +++ b/vowpalwabbit/fb_parser/tests/read_span_tests.cc @@ -152,7 +152,7 @@ Offset create_bad_ns_root_example(FlatBufferBuilder& builder, VW::w { std::vector> namespaces = { ns_fac(builder, w) }; - Offset<> label_offset = fb::Createno_label(builder).Union(); + Offset label_offset = fb::Createno_label(builder).Union(); return fb::CreateExample(builder, builder.CreateVector(namespaces), fb::Label_no_label, label_offset); } @@ -185,7 +185,7 @@ template void create_flatbuffer_span_and_expect_error(VW::workspace& w, namespace_factory_f ns_fac, builder_f root_builder) { FlatBufferBuilder builder; - Offset<> data_obj = root_builder(builder, w, ns_fac).Union(); + Offset data_obj = root_builder(builder, w, ns_fac).Union(); Offset root_obj = fb::CreateExampleRoot(builder, root_type, data_obj);