Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upload file feature to editable rows for business table feature #242

Open
windmillcode0 opened this issue Feb 9, 2025 · 4 comments · May be fixed by #247
Open

Add Upload file feature to editable rows for business table feature #242

windmillcode0 opened this issue Feb 9, 2025 · 4 comments · May be fixed by #247
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@windmillcode0
Copy link

Greetings we appreciate the use of business image but we were wonderning if there could be a use case for file upload in the edit feature of business tables. It can be from there converted to base64 and sent to the approrpiate data source. We would greatly appreciate this feature instead of having to build a business form just to update a file in the business image table

In addition does the image display any file type or they have to be images?

@vitPinchuk vitPinchuk self-assigned this Feb 11, 2025
@vitPinchuk vitPinchuk added the question Further information is requested label Feb 11, 2025
@vitPinchuk vitPinchuk added this to the Table 2.2.0 milestone Feb 11, 2025
@windmillcode0
Copy link
Author

Image
Greetings were working on this as we speak but we dont quite understand what happens after useDataSourceRequest, it keeps turning the file array (even when we base64 stringify the content and make the file an object) we get [object Object] in the server.

The @volkovlabs/components library is not public and even with the sourceMaps its hard to understand whats going on

@mikhail-vl mikhail-vl modified the milestones: Table 2.2.0, Table 2.3.0 Feb 12, 2025
@windmillcode0
Copy link
Author

windmillcode0 commented Feb 12, 2025

Greetings we have implemented the changes how should we go about making a PR? https://github.com/VolkovLabs/business-table/pull/247/files

@mikhail-vl mikhail-vl linked a pull request Feb 12, 2025 that will close this issue
@mikhail-vl
Copy link
Member

@windmillcode0 Thank you for your contribution!

Our packages and components are public: https://github.com/VolkovLabs/business-packages
I asked team to review PR and target it for the upcoming release.

@mikhail-vl mikhail-vl self-assigned this Feb 12, 2025
@mikhail-vl mikhail-vl added enhancement New feature or request and removed question Further information is requested labels Feb 12, 2025
@windmillcode0
Copy link
Author

windmillcode0 commented Feb 12, 2025

Greetings we have a few more enhancements we would like to see or implement

  • Joined sub tables(situations where you want 2 or more sub tables to be in the same sub table visually)
  • The sorting of columns in sub tables

We would also like to confirm that the dateime picker is locale specfic meaning the datetime will make sense according to the users locale. In addition we would like to add the option to disable keyboard input. It seems the grafana datetime picker is lacking after talking to their team, hopefully you can extend it
We would also like to know when when a datasource for an add edit or delete command fails, the panel still reports success we see this error in the code and would like to update it as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants