From fa8cce334e0a445dbb7e6f6b343b4eccad3e6633 Mon Sep 17 00:00:00 2001 From: xile611 Date: Fri, 9 Aug 2024 13:29:42 +0800 Subject: [PATCH 1/2] fix: fix `padding` of region not work --- packages/vchart/src/layout/base-layout.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/vchart/src/layout/base-layout.ts b/packages/vchart/src/layout/base-layout.ts index 3044517204..f5984b51a8 100644 --- a/packages/vchart/src/layout/base-layout.ts +++ b/packages/vchart/src/layout/base-layout.ts @@ -285,9 +285,12 @@ export class Layout implements IBaseLayout { 0 ); regionItems.forEach(region => { + const width = regionWidth - region.layoutPaddingLeft - region.layoutPaddingRight; + const height = regionHeight - region.layoutPaddingTop - region.layoutPaddingBottom; + region.setLayoutRect({ - width: regionWidth, - height: regionHeight + width: width, + height: height }); region.setLayoutStartPosition({ From 4fab2811f559bb7c815977d0e2dfd43fa8af844c Mon Sep 17 00:00:00 2001 From: xile611 Date: Fri, 9 Aug 2024 13:30:17 +0800 Subject: [PATCH 2/2] docs: update changlog of rush --- .../vchart/feat-region-padding_2024-08-09-05-30.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@visactor/vchart/feat-region-padding_2024-08-09-05-30.json diff --git a/common/changes/@visactor/vchart/feat-region-padding_2024-08-09-05-30.json b/common/changes/@visactor/vchart/feat-region-padding_2024-08-09-05-30.json new file mode 100644 index 0000000000..79cee72f5c --- /dev/null +++ b/common/changes/@visactor/vchart/feat-region-padding_2024-08-09-05-30.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "fix: fix `padding` of region not work\n\n", + "type": "none", + "packageName": "@visactor/vchart" + } + ], + "packageName": "@visactor/vchart", + "email": "dingling112@gmail.com" +} \ No newline at end of file