From cf8f904897e39f9f7f19b02e485c064b25ae1254 Mon Sep 17 00:00:00 2001 From: xiaoluoHe Date: Wed, 20 Dec 2023 16:53:04 +0800 Subject: [PATCH 1/2] fix: `select.triggerOff: none` not work --- packages/vchart/src/interaction/trigger.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/vchart/src/interaction/trigger.ts b/packages/vchart/src/interaction/trigger.ts index 0208b6e23a..d9a3de2ffc 100644 --- a/packages/vchart/src/interaction/trigger.ts +++ b/packages/vchart/src/interaction/trigger.ts @@ -212,11 +212,14 @@ export class Trigger implements ITrigger { } protected unselectItems(params: BaseEventParams): void { - this.interaction.removeEventElement(STATE_VALUE_ENUM.STATE_SELECTED, params.item); - this.event.emit('unselected', { - model: this._option.model, - value: params.item - }); + const { triggerOff } = this._select; + if (triggerOff !== 'none') { + this.interaction.removeEventElement(STATE_VALUE_ENUM.STATE_SELECTED, params.item); + this.event.emit('unselected', { + model: this._option.model, + value: params.item + }); + } } protected handleSingleEventSelect(params: BaseEventParams): void { From 91dc77be3454c9ea06519f604d823a7dd34c6447 Mon Sep 17 00:00:00 2001 From: xiaoluoHe Date: Wed, 20 Dec 2023 16:54:03 +0800 Subject: [PATCH 2/2] docs: add change log --- .../vchart/fix-select_triggerOff_2023-12-20-08-53.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 common/changes/@visactor/vchart/fix-select_triggerOff_2023-12-20-08-53.json diff --git a/common/changes/@visactor/vchart/fix-select_triggerOff_2023-12-20-08-53.json b/common/changes/@visactor/vchart/fix-select_triggerOff_2023-12-20-08-53.json new file mode 100644 index 0000000000..a8f34e604c --- /dev/null +++ b/common/changes/@visactor/vchart/fix-select_triggerOff_2023-12-20-08-53.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@visactor/vchart", + "comment": " fix: `select.triggerOff: none` not work", + "type": "none" + } + ], + "packageName": "@visactor/vchart" +} \ No newline at end of file