Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Preview image can't be loaded #2817

Closed
mengxi-ream opened this issue Jun 16, 2024 · 3 comments · Fixed by #2821
Closed

[Docs] Preview image can't be loaded #2817

mengxi-ream opened this issue Jun 16, 2024 · 3 comments · Fixed by #2821
Assignees
@xiaoluoHe @purpose233

Comments

@mengxi-ream
Copy link
Contributor

mengxi-ream commented Jun 16, 2024 •
edited
Loading

I found the preview image relevant to my PR #2760 was not loaded.

To fix, should I change the relative path from cover: ../../../../public/vchart/preview/bar-customized-label-en_1.11.1.png to cover: /vchart/preview/bar-customized-label-en_1.11.1.png?
@mengxi-ream
Copy link
Contributor Author

I can create a new PR to fix this if my suggestion above is correct.

@xiaoluoHe
Copy link
Contributor

Yes, relative paths should not be used. The writing style starting with /vchart is correct.

@mengxi-ream
Copy link
Contributor Author

mengxi-ream commented Jun 18, 2024 •
edited
Loading

Yes, relative paths should not be used. The writing style starting with /vchart is correct.

Alright, I'll handle this

@mengxi-ream mengxi-ream mentioned this issue Jun 18, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaoluoHe xiaoluoHe

@purpose233 purpose233

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix path of preview image and relavant docs mengxi-ream/VChart
3 participants
@xiaoluoHe @purpose233 @mengxi-ream