Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image for JVM platform contains fixed JVM 8 by default #413

Closed
tpasternak opened this issue Nov 24, 2021 · 2 comments
Closed

Docker Image for JVM platform contains fixed JVM 8 by default #413

tpasternak opened this issue Nov 24, 2021 · 2 comments

Comments

@tpasternak
Copy link
Contributor

This causes runtime failure, if a user builds. code to jvm 11

so the app in image built with scala-cli package --docker --jvm 11 will fail to start

https://github.com/tpasternak/scala-cli/blob/shebang-args/modules/cli/src/main/scala/scala/cli/commands/Package.scala#L355

@alexarchambault
Copy link
Contributor

We should probably change that depending on --jvm. At least default to openjdk 8 / 11 / 17 images, picking a version higher than or equal to the one of the JVM passed via --jvm when possible.

We might also check if there are specific docker images for specific JVMs (zulu, graalvm, etc.), although that looks a bit like an overkill…

@tpasternak
Copy link
Contributor Author

It's now bumped to jvm 11, closing for now

case Platform.JVM => "openjdk:11-jre-slim"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants