Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zotero plugin and remove restrictions on number of articles required to make recommendations using S2 #53

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

gurdeep330
Copy link
Member

@gurdeep330 gurdeep330 commented Aug 23, 2024

For authors

Description

  1. Plugin to write articles to a Zotero account
  2. Consider any number of positive as well as articles to make recommendations using Semantic Scholar

Fixes # (issue) NA

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.

  • Added new test(s) in the tests folder
  • Added new function(s) to an existing test(s) (e.g.: tests/testX.py)
  • No new tests added (Work in progress ref BUG: Test for utils.py missing #52)

Checklist

  • My code follows the style guidelines mentioned in the Code/DevOps guides
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. MkDocs)
  • My changes generate no new warnings
  • I have added or updated tests (in the tests folder) that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For reviewers

Checklist pre-approval

  • Is there enough documentation?
  • If a new feature has been added, or a bug fixed, has a test been added to confirm good behaviour?
  • Does the test(s) successfully test edge/corner cases?
  • Does the PR pass the tests? (if the repository has continuous integration)

Checklist post-approval

  • Does this PR merge develop into main? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.
  • Does this PR close an issue? If so, please make sure to descriptively close this issue when the PR is merged.

Checklist post-merge

  • When you approve of the PR, merge and close it (Read this article to know about different merge methods on GitHub)
  • Did this PR merge develop into main and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.

gurdeep330 and others added 5 commits August 8, 2024 13:19
fix: changes on positive and negative articles due to Semantic Scholar Recommendation API restriction removal, close #47
* update data

* update data

* feat: add Zotero plugin

* chore: update README explaining the Zotero plugin

* chore: utils.py and reduce the number of articles to 200

---------

Co-authored-by: GitHub Action <action@github.com>
@gurdeep330 gurdeep330 added bug Something isn't working enhancement New feature or request labels Aug 23, 2024
@gurdeep330 gurdeep330 self-assigned this Aug 23, 2024
@gurdeep330 gurdeep330 changed the title Develop Add Zotero plugin and remove restrictions on number of articles required to make recommendations using S2 Aug 23, 2024
@gurdeep330 gurdeep330 merged commit de94c38 into main Aug 23, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
# [2.5.0](v2.4.0...v2.5.0) (2024-08-23)

### Features

* Add Zotero plugin and remove restrictions on number of articles required to make recommendations using S2 ([#53](#53)) ([de94c38](de94c38)), closes [/github.com/VirtualPatientEngine/VPECompetitiveIntelligence/issues/3#issue-2471909877](https://github.com//github.com/VirtualPatientEngine/VPECompetitiveIntelligence/issues/3/issues/issue-2471909877) [#47](#47) [#51](#51)
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Sep 5, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants