Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error boundaries to catch all issues triggered by react #330

Closed
ddelpiano opened this issue Apr 23, 2019 · 1 comment
Closed

Error boundaries to catch all issues triggered by react #330

ddelpiano opened this issue Apr 23, 2019 · 1 comment
Assignees

Comments

@ddelpiano
Copy link
Contributor

No description provided.

@ddelpiano ddelpiano added this to the Metacell 230419 milestone Apr 23, 2019
@ddelpiano ddelpiano self-assigned this Apr 23, 2019
@ddelpiano
Copy link
Contributor Author

@Robbie1977 this is now implemented in the geppetto-application branch, I am porting shortly in the release_march_2019 branch as well so you can deploy it when you wish.

Quick overview, this now catches all the issue within the VFB render's application, so all the components declared inside VFB will be covered by the ErrorCatcher component.
This has been defined in the ComponentInitialization/Main outside the router in order to cover all the possible scenarios.
At the moment this is the way I implemented, I show a dialog reporting an issue just occurred asking the user if he wants to reload the app or report the issue (through github), the report is actually useful since I am include error message, stack and asking to fill the steps to reproduce the problem.
If you prefer to reload straight that is a small change for me.

Virtual Fly Brain.png

New Issue · VirtualFlyBrain VFB2.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant