Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design color classification for nodes in circuit browser #1117

Open
ddelpiano opened this issue Apr 26, 2021 · 2 comments
Open

Design color classification for nodes in circuit browser #1117

ddelpiano opened this issue Apr 26, 2021 · 2 comments
Assignees

Comments

@ddelpiano
Copy link
Contributor

ddelpiano commented Apr 26, 2021

We currently colour nodes based on NEO:Label assuming 1 label per term, but this assumption will not hold in future. While I think it is unlikely that nodes will have more that 2-3 classifications max, I think it is reasonable to support a max of 5.

Suggested solution
image
image

Divide the top panel, which is currently used to display the colour, into n segments where n = number of labels, with a max of n=5. Each segment takes one colour.

The aim of this ticket is a solution to this UI issue. The following text deals with the issue of generating a non-redundant list of labels. It should be used as the starting point for further tickets.

Note - the queries themselves may return a relatively large, partly redundant list of labels for each node. We will provide a data structure + an algorithm for operating on it which will allow this to be reduced to a small, non-redundant list. Right now, this data-structure consists of a single ranked-order list. We may stick with this arrangement in order to release MVP, but this will be replaced by a graph structure that can be used to determine a non-redundant list of labels to apply, given any label input. Note - the same problem of displaying non-redundant label lists is faced elsewhere in the app, so ideally the data-structure and the code for using it will be centralised.

@ddelpiano
Copy link
Contributor Author

As per last sprint, place holder to grab the requirements of the desired implementation.

@ddelpiano
Copy link
Contributor Author

  • note related to this change, we need also to highlight in the circuit browser the instances that already part of the scene
  • suggestion from David to use the same color assigned to the instance (colorpicker color).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants