Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we throw an error if non existent parameters are passed to the pool creation #19

Closed
elhigu opened this issue Feb 12, 2019 · 1 comment · Fixed by #32
Closed

Comments

@elhigu
Copy link
Collaborator

elhigu commented Feb 12, 2019

I saw bunch of deprecated code in knex, that is trying to check and give warnings if invalid parameters are passed to tarn (checked parameter list actually didn't match with tarn...).

To me it would be more reasonable to do parameter validation by tarn instead of trying to keep up with correct attributes in knex side. Probably knex had that code, because of its old habit of changing pool on every release.

Downside of this is that throwing an error on invalid parameter would be a breaking change. I could live with that though.

@koskimas
Copy link
Collaborator

Seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants