Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address binding #73

Closed
mttmccb opened this issue Aug 21, 2017 · 4 comments
Closed

Address binding #73

mttmccb opened this issue Aug 21, 2017 · 4 comments

Comments

@mttmccb
Copy link

mttmccb commented Aug 21, 2017

Unless I'm missing something very obvious this doesn't appear to be implemented although it's in the docs, I've hunted the source code for a reference to address but it doesn't appear to be there.

I'm getting the address from an API call and then binding that to the maps component but it's just in the middle of the ocean.

@serifine
Copy link

I was wondering the same. It appears to be removed in these two merges:
1010d04
efc6445

@tomtomau
Copy link
Contributor

Correct, we removed this in favour of using the GoogleMapsAPI to geocode an address. In a reasonable UX you're likely to have multiple results for the search query and the user may want to select one. You'll receive the latitude and longitude which you can then bind into the component.

Apologies on it still remaining in the docs, I've raised a pull request at #75

@Vheissu
Copy link
Owner

Vheissu commented Sep 19, 2017

This has been merged in. I'll get this released ASAP.

@Vheissu
Copy link
Owner

Vheissu commented Oct 10, 2017

Released in version 2.1.0.

@Vheissu Vheissu closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants