Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seus based code shader not render correctly #339

Open
azurawrtata opened this issue Dec 24, 2024 · 37 comments
Open

Seus based code shader not render correctly #339

azurawrtata opened this issue Dec 24, 2024 · 37 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@azurawrtata
Copy link

I've created a issue before about Seus based shader cant be rendered at all on Snapdragon processor. But since the custom driver features were added , this finally fixes it.

Even though there's still a cons where this driver only works on older shader but newer shader dont. So it had to be switched whenever if i wanna use either new or old one. If there's a way to merge this turnip driver to current latest turnip driver , that would be fantastic.

That said, newer Mesa also doesn't go well with this driver , only 23.0.4 , 23.0.0-devel and 23.1.9 works.

IMG_20241224_22515863

@Vera-Firefly
Copy link
Owner

Can you provide the source of the driver code?

@Vera-Firefly Vera-Firefly added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Dec 24, 2024
@azurawrtata
Copy link
Author

Can you provide the source of the driver code?

Here's the page : https://github.com/K11MCH1/AdrenoToolsDrivers/releases/tag/A7xx_R4

@Vera-Firefly
Copy link
Owner

Vera-Firefly commented Dec 24, 2024

Can you provide the source of the driver code?

Here's the page : https://github.com/K11MCH1/AdrenoToolsDrivers/releases/tag/A7xx_R4

Thanks for your offer

@azurawrtata
Copy link
Author

Hang on i found another working one , but this one fixes the issue that has on Rev 4 (Black bar flickering on screen)

This version fixes it.
https://github.com/K11MCH1/AdrenoToolsDrivers/releases/tag/v23.3.0_R5

Somehow i missed it while scrolling through 🥲. The release page says 23.2.0 , but the file says 23.3.0. Its either typo or this is the only working 23.3.0 driver. Maybe try look into this one aswell 😀. As always the Mesa only works on the 3 version i state above.

@Vera-Firefly
Copy link
Owner

Can you test higher version? This will help us a lot.

@azurawrtata
Copy link
Author

Can you test higher version? This will help us a lot.

You mean lastest turnip version or Mesa?

@Vera-Firefly
Copy link
Owner

Can you test higher version? This will help us a lot.

You mean lastest turnip version or Mesa?

Turnip

@azurawrtata
Copy link
Author

Can you test higher version? This will help us a lot.

You mean lastest turnip version or Mesa?

Turnip

There's dozen of it ,but i can already guarantee that Turnip v25 and v24 drivers will not work. And after couple of testing on v23 drivers only v23.2.0 drivers work (any Revisions) 23.3.0 wont either.

This is the result of v25 (lastest) and v24 (lastest rev). Mesa 23.1.9. (Mesa 24 above remain broken)
Screenshot_2024-12-25-01-36-43-64_405a2fc07b254ef5ee3229f4fec175cf

@azurawrtata
Copy link
Author

Screenshot_2024-12-25-01-41-12-36_405a2fc07b254ef5ee3229f4fec175cf

Here's are the turnip that i found working. For 23.3.0R5 one, its from the reply i made about the typo on the release page (It's written 23.2.0R5). And i don't know if its V23.3 or V23.2.

@Vera-Firefly
Copy link
Owner

Okay, I see. Thanks for your help

@azurawrtata
Copy link
Author

Okay, I see. Thanks for your help

Glad to be help and good luck!

@Vera-Firefly
Copy link
Owner

@Vera-Firefly
Copy link
Owner

@azurawrtata
Copy link
Author

@Vera-Firefly
Copy link
Owner

https://github.com/K11MCH1/AdrenoToolsDrivers/releases/tag/v23.3.0_R6 does it can work?

Nope

Okay, i got it

@Vera-Firefly
Copy link
Owner

By the way, you can try this: https://github.com/Vera-Firefly/freedreno-auto-builder/actions/runs/12484807604

Try this, if it can work, I'm going to start right here

@azurawrtata
Copy link
Author

By the way, you can try this: https://github.com/Vera-Firefly/freedreno-auto-builder/actions/runs/12484807604

Um. It crashed immediately. Tried 3 different Mesa aswell.

Here's log :
latestlog.zip

@Vera-Firefly
Copy link
Owner

By the way, you can try this: https://github.com/Vera-Firefly/freedreno-auto-builder/actions/runs/12484807604

Um. It crashed immediately. Tried 3 different Mesa aswell.

Here's log : latestlog.zip

Wait a while while I try to fix it

@Vera-Firefly
Copy link
Owner

It may take some time

@azurawrtata
Copy link
Author

By the way, you can try this: https://github.com/Vera-Firefly/freedreno-auto-builder/actions/runs/12484807604

Try this, if it can work, I'm going to start right here

Crash too.
latestlog.zip

@azurawrtata
Copy link
Author

It may take some time

It's alright,take your time. This issue is kinda difficult afterall. (Took me almost a year to figure this out 😭)

@Vera-Firefly
Copy link
Owner

It may take some time

It's alright,take your time. This issue is kinda difficult afterall. (Took me almost a year to figure this out 😭)

Screenshot_2024-12-25-02-16-39-244_bin mt plus

The problem is that it is not configured correctly

@Vera-Firefly
Copy link
Owner

If possible, I need to keep in touch with you in the near future.

@azurawrtata
Copy link
Author

If possible, I need to keep in touch with you in the near future.

Sure im always free. Especially till Dec 28 since im having Christmas day off right now.

@Vera-Firefly
Copy link
Owner

If possible, I need to keep in touch with you in the near future.

I tried to port the features of those drivers from the later version to 23.2.0-rc4

@azurawrtata
Copy link
Author

If possible, I need to keep in touch with you in the near future.

I tried to port the features of those drivers from the later version to 23.2.0-rc4

Im not a expert , but i hope its working 🥲.

@Vera-Firefly
Copy link
Owner

If possible, I need to keep in touch with you in the near future.

Sure im always free. Especially till Dec 28 since im having Christmas day off right now.

Thanks a lot.This will better help us carry out our work and deal with problems

@Vera-Firefly
Copy link
Owner

Vera-Firefly commented Dec 26, 2024

If possible, I need to keep in touch with you in the near future.

I tried to port the features of those drivers from the later version to 23.2.0-rc4

Im not a expert , but i hope its working 🥲.

It seems to be a little difficult, and I'm not particularly good at dealing with this aspect of driving
It may not be possible
The commits were too old, and I couldn't get exact branch names and commits

@azurawrtata
Copy link
Author

If possible, I need to keep in touch with you in the near future.

I tried to port the features of those drivers from the later version to 23.2.0-rc4

Im not a expert , but i hope its working 🥲.

It seems to be a little difficult, and I'm not particularly good at dealing with this aspect of driving It may not be possible The commits were too old, and I couldn't get exact branch names and commits

Oh.. Well thats unfortunate. Well its alright at least the shader issue already been founded due to drivers.

@azurawrtata
Copy link
Author

But i think in the future updates you should include this driver on Turnip driver settings. That way its easy to switch it. This is ideal to those who prefer to use old shaders rather than newer shaders.

@Vera-Firefly
Copy link
Owner

But i think in the future updates you should include this driver on Turnip driver settings. That way its easy to switch it. This is ideal to those who prefer to use old shaders rather than newer shaders.

Good idea, I will try to make a feature to implement it

@Vera-Firefly Vera-Firefly changed the title Turnip 23.2.0 Rev 4 SEUS shader not render correctly Dec 27, 2024
@Vera-Firefly Vera-Firefly added the good first issue Good for newcomers label Dec 27, 2024
@Vera-Firefly Vera-Firefly pinned this issue Dec 27, 2024
@azurawrtata
Copy link
Author

This should be "Seus based code shader" , because Continuum 1.3 , Beyond Belief and IterationT uses same code from SEUS (Except SEUS Renewed and SEUS PTGI)

But still the same thing though 😅

@Vera-Firefly Vera-Firefly changed the title SEUS shader not render correctly SEUS/Seus based code shader not render correctly Dec 27, 2024
@Vera-Firefly Vera-Firefly changed the title SEUS/Seus based code shader not render correctly [SEUS/Seus based code] shader not render correctly Dec 27, 2024
@Vera-Firefly Vera-Firefly changed the title [SEUS/Seus based code] shader not render correctly Seus based code shader not render correctly Dec 27, 2024
@HenryLogic
Copy link

I build a 23.2 turnip driver and discover it can run seus-v11 and Bliss_v2.0.4_(Chocapic13_Shaders_edit). On newer turnip driver I meet the same problem as you. By the way , the 23.2 driver has a worse performance and fps is lower on my phone, so I think switch the turnip driver is a better choice so far.

https://github.com/HenryLogic/freedreno-auto-builder/actions/runs/12519957688/artifacts/2366623640

@azurawrtata
Copy link
Author

I build a 23.2 turnip driver and discover it can run seus-v11 and Bliss_v2.0.4_(Chocapic13_Shaders_edit). On newer turnip driver I meet the same problem as you. By the way , the 23.2 driver has a worse performance and fps is lower on my phone, so I think switch the turnip driver is a better choice so far.

https://github.com/HenryLogic/freedreno-auto-builder/actions/runs/12519957688/artifacts/2366623640

Im using v23.3.0 R5 (Which is the only working v23.3 driver that can render SEUS) and its already stable enough to me. Using any v23.2 driver will lead to black bar flickering on the screen.

@azurawrtata
Copy link
Author

I build a 23.2 turnip driver and discover it can run seus-v11 and Bliss_v2.0.4_(Chocapic13_Shaders_edit). On newer turnip driver I meet the same problem as you. By the way , the 23.2 driver has a worse performance and fps is lower on my phone, so I think switch the turnip driver is a better choice so far.

https://github.com/HenryLogic/freedreno-auto-builder/actions/runs/12519957688/artifacts/2366623640

This driver crashes when i run the game 😅.

@HenryLogic
Copy link

I build a 23.2 turnip driver and discover it can run seus-v11 and Bliss_v2.0.4_(Chocapic13_Shaders_edit). On newer turnip driver I meet the same problem as you. By the way , the 23.2 driver has a worse performance and fps is lower on my phone, so I think switch the turnip driver is a better choice so far.
https://github.com/HenryLogic/freedreno-auto-builder/actions/runs/12519957688/artifacts/2366623640

This driver crashes when i run the game 😅.

Sorry, it seems that there are many differences between our devices... Turnip driver 23.2 is the perfect one for me to run seus while 23.3.0 can not work correctly.

@azurawrtata
Copy link
Author

I build a 23.2 turnip driver and discover it can run seus-v11 and Bliss_v2.0.4_(Chocapic13_Shaders_edit). On newer turnip driver I meet the same problem as you. By the way , the 23.2 driver has a worse performance and fps is lower on my phone, so I think switch the turnip driver is a better choice so far.
https://github.com/HenryLogic/freedreno-auto-builder/actions/runs/12519957688/artifacts/2366623640

This driver crashes when i run the game 😅.

Sorry, it seems that there are many differences between our devices... Turnip driver 23.2 is the perfect one for me to run seus while 23.3.0 can not work correctly.

I can actually run v23.2 drivers , its just the one you provided to me crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants