Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the package with newer variants of MS-SSIM #25

Open
danieltudosiu opened this issue Feb 15, 2021 · 1 comment
Open

Extend the package with newer variants of MS-SSIM #25

danieltudosiu opened this issue Feb 15, 2021 · 1 comment

Comments

@danieltudosiu
Copy link

danieltudosiu commented Feb 15, 2021

What are your thoughts about extending the library to include the following metrics:

  • 3-SSIM
  • 3-MS-SSIM
  • G-SSIM
  • G-MS-SSIM
  • 3-G-SSIM
  • 3-G-MS-SSIM
  • 4-SSIM
  • 4-MS-SSIM
  • 4-G-SSIM
  • 4-G-MS-SSIM

From a quick look, the required changes are:

  • Decoupling the scalar SSIM calculation from the calculation of the SSIM map (here).
  • Allowing for padding during the SSIM map calculation (here).

An implementation choice that I did not understand is why do you apply multiple 1D gaussian smoothings (here) instead of a 2D or 3D one. Could you please explain it?

What would you think about a collaboration to extend the codebase and improve it?

@danieltudosiu
Copy link
Author

@VainF I have based my implementation of the metrics I outlined in the original post on your library.

I am to submit a push request to MONAI after I benchmark it against another open-source implementation in JAVA.

How would you like to be acknowledged in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant