Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Explorer right-click menu shows "Open with VSCodium", pressing underlined S creates shortcut instead #250

Closed
2 tasks done
nyanpasu64 opened this issue Sep 1, 2019 · 2 comments · Fixed by #258
Closed
2 tasks done
Labels
good first issue Good for newcomers

Comments

@nyanpasu64
Copy link

Describe the bug
When I install VSCodium and right-click a file or folder, the "Open With VSCodium" has the S underlined, but when I press S, it creates a shortcut instead of opening with vscodium.

Please confirm that this problem is VSCodium-specific

  • This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

Please confirm that the issue/resolution isn't already documented

To Reproduce
Steps to reproduce the behavior:

  1. Install VSCodium (maybe you need to enable adding Windows Explorer right-click menu options)
  2. Open Windows Explorer, focus (click) a file, and press the keyboard right-click menu key
  3. See the vscodium entry, notice S is underlined, and try to press S
  4. It creates a shortcut instead of opening vscodium

Expected behavior
The underlined key opens vscodium.

win32ShellNameShort='setpath(["win32ShellNameShort"]; "V&SCodium")'
shows that "V&SCodium" and the S is meant to be underlined.

Opening ShellMenuView and searching codium, vscodium creates 4 registry entries and uses "Open W&ith V&SCodium" for all 4, indicating both "ith" and "SCodium" are "meant" to be underlined, but the second underline overrides the first.

I think the second ampersand should be removed, since there shouldn't be two ampersands, and the current setup makes it difficult to open a file in vscodium via the keyboard alone. (With the second ampersand removed, I can open files in vscodium in two keystrokes, by pressing "menu" key and "i".)

Honestly this issue may be language-specific, and "pressing S creates shortcut" is the case in English but possibly not other languages. But having 2 underlined keys seems like a bad design in of itself. Was it done to avoid clashing with Open W&ith Code or similar?

Screenshots
If applicable, add screenshots to help explain your problem.

vscodium

Desktop (please complete the following information):

  • OS: Windows 10
  • Architecture x64
  • Version 1.37.1

Additional context
Add any other context about the problem here.

@nyanpasu64 nyanpasu64 added the bug Something isn't working label Sep 1, 2019
@stripedpajamas
Copy link
Member

Thanks for calling this out @jimbo1qaz ! When I first wrote the build script and included the changes to product.json, I really had no idea what the ampersand affected. Your explanation makes a lot of sense.

To clarify -- is the recommendation to change win32ShellNameShort='setpath(["win32ShellNameShort"]; "V&SCodium")' to win32ShellNameShort='setpath(["win32ShellNameShort"]; "VSCodium")' ?

@stripedpajamas stripedpajamas added good first issue Good for newcomers and removed bug Something isn't working labels Sep 13, 2019
@nyanpasu64
Copy link
Author

That seems like a reasonable change to make, and replicates what I did manually to the registry. I hope it doesn't have any unexpected side effects though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants