Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for UNLEASH_URL to values file #181

Open
mattiasbpersson opened this issue Jan 24, 2025 · 1 comment
Open

Add configuration for UNLEASH_URL to values file #181

mattiasbpersson opened this issue Jan 24, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mattiasbpersson
Copy link

mattiasbpersson commented Jan 24, 2025

Describe the feature request

We missed how we should configure the UNLEASH_URL to get the slack-notification working. We found that documentations for it and gave it a try.

Would be great is this is included in the values file too:
https://docs.getunleash.io/using-unleash/deploy/configuring-unleash#unleash-url

The same for
UNLEASH_DEFAULT_ADMIN_USERNAME
UNLEASH_DEFAULT_ADMIN_PASSWORD

Background

No response

Solution suggestions

https://github.com/Unleash/helm-charts/blob/main/charts/unleash/values.yaml#L64C1-L68C58

env: []
#  - name: UNLEASH_URL
#    value: <Should be set to the public discoverable URL of your instance, so if your instance is accessed by your users >
#  - name: UNLEASH_DEFAULT_ADMIN_USERNAME
#    value: The initial admin username
#  - name: UNLEASH_DEFAULT_ADMIN_PASSWORD
#    value: The initial admin password
@gastonfournier
Copy link
Contributor

Hi @mattiasbpersson it seems reasonable, please feel free to open a PR suggesting that change.

@gastonfournier gastonfournier moved this from New to Investigating in Issues and PRs Jan 28, 2025
@gastonfournier gastonfournier added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Investigating
Development

No branches or pull requests

2 participants