Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollup errors #540

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix: rollup errors #540

merged 1 commit into from
Mar 7, 2023

Conversation

just-toby
Copy link
Collaborator

for some reason, changing these consts to regular function syntax fixes the rollup errors that we've been seeing (in the terminal when running yarn start)

example of the error:

rollup building...
Error when using sourcemap for reporting an error: Can't resolve original location of error.
{
  column: 13,
  file: '/Users/eddie.dugan/Documents/widgets/src/components/Swap/Toolbar/Caption.tsx',
  line: 4
} 

The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
{
  column: 13,
  file: '/Users/eddie.dugan/Documents/widgets/src/components/Swap/Toolbar/Caption.tsx',
  line: 4
} 

to verify that this actually fixes the errors like I claim, checkout this branch and run yarn && yarn start

@just-toby just-toby requested a review from zzmp March 7, 2023 01:54
@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
widgets ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 1:59AM (UTC)

@vercel vercel bot temporarily deployed to Preview March 7, 2023 01:59 Inactive
@just-toby just-toby merged commit 02fe1b1 into main Mar 7, 2023
@just-toby just-toby deleted the fix/rollup-errors branch March 7, 2023 17:58
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version 2.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants