Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support celo #287

Merged
merged 8 commits into from
Oct 27, 2022
Merged

feat: support celo #287

merged 8 commits into from
Oct 27, 2022

Conversation

Jesse-Sawa
Copy link
Contributor

@Jesse-Sawa Jesse-Sawa commented Oct 18, 2022

This change also includes removing lists from the repository.

Screenshots of Celo widget support using the interface
Screen Shot 2022-10-20 at 11 55 25 AM

@vercel
Copy link

vercel bot commented Oct 18, 2022

@Jesse-Sawa is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

@Jesse-Sawa Jesse-Sawa changed the title feat: support celo feat: support celo [WIP] Oct 20, 2022
@Jesse-Sawa Jesse-Sawa changed the title feat: support celo [WIP] feat: support celo Oct 20, 2022
@zzmp zzmp self-requested a review October 24, 2022 18:52
src/constants/addresses.ts Outdated Show resolved Hide resolved
src/utils/getExplorerLink.ts Outdated Show resolved Hide resolved
src/utils/getExplorerLink.test.ts Show resolved Hide resolved
src/constants/routing.ts Outdated Show resolved Hide resolved
src/constants/routing.ts Outdated Show resolved Hide resolved
src/constants/routing.ts Outdated Show resolved Hide resolved
src/constants/routing.ts Outdated Show resolved Hide resolved
src/constants/tokens.ts Outdated Show resolved Hide resolved
src/hooks/useCurrencyLogoURIs.ts Outdated Show resolved Hide resolved
@Jesse-Sawa Jesse-Sawa requested a review from zzmp October 25, 2022 21:27
@@ -46,7 +46,7 @@ function getTokenLogoURI(address: string, chainId: SupportedChainId = SupportedC
// Celo logo is hosted elsewhere.
if (isCelo(chainId)) {
if (address === nativeOnChain(chainId).wrapped.address) {
return 'https://raw.githubusercontent.com/ubeswap/default-token-list/master/assets/asset_CELO.png'
return 'https://celo-org.github.io/celo-token-list/assets/celo_alternative_logo.png'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the alternative logo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative logo (yellow and white) is used for erc-20 transfers and is consistent with other applications on Celo. The green and yellow icon normally represents the network itself.

For UI consistency; Celo on the celo token list (and others alike) use the alternative logo to represent $CELO. If $CELO is selected from the token list, the same logo should be displayed on the swap widget.

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
widgets ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 11:22PM (UTC)

Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a comment inline to explain why you are using the alternative logo (ie brand guideline reference).

@vercel vercel bot temporarily deployed to Preview October 27, 2022 18:57 Inactive
@zzmp zzmp merged commit 83f3215 into Uniswap:main Oct 27, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants