-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support celo #287
feat: support celo #287
Conversation
@Jesse-Sawa is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
5a6b87b
to
b4797bc
Compare
30501e4
to
4232c45
Compare
…AIRS' since widget doesn't use these features/properties
050d76b
to
2ca5513
Compare
@@ -46,7 +46,7 @@ function getTokenLogoURI(address: string, chainId: SupportedChainId = SupportedC | |||
// Celo logo is hosted elsewhere. | |||
if (isCelo(chainId)) { | |||
if (address === nativeOnChain(chainId).wrapped.address) { | |||
return 'https://raw.githubusercontent.com/ubeswap/default-token-list/master/assets/asset_CELO.png' | |||
return 'https://celo-org.github.io/celo-token-list/assets/celo_alternative_logo.png' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this the alternative logo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative logo (yellow and white) is used for erc-20 transfers and is consistent with other applications on Celo. The green and yellow icon normally represents the network itself.
For UI consistency; Celo on the celo token list (and others alike) use the alternative logo to represent $CELO. If $CELO is selected from the token list, the same logo should be displayed on the swap widget.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending a comment inline to explain why you are using the alternative logo (ie brand guideline reference).
🎉 This PR is included in version 2.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change also includes removing lists from the repository.
Screenshots of Celo widget support using the interface